Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-1324] Fix the CLI failing to return wrapping information for KV PUT and PATCH operations when format is set to 'table' #22818

Merged
merged 5 commits into from Sep 7, 2023
Merged

[VAULT-1324] Fix the CLI failing to return wrapping information for KV PUT and PATCH operations when format is set to 'table' #22818

merged 5 commits into from Sep 7, 2023
+13 −0

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Sep 6, 2023 •
edited

The CLI currently fails to output the wrapping info for vault kv patch and vault kv put commands.

Output before:
image

Output after:
image

The fix was copied from a PR that fixed the same problem for vault kv list: #12031

@kubawi
VAULT-1324 Fix the CLI failing to return wrapping information for KV …
df149d6 
…PUTs and PATCHes when format is set to 'table'
@kubawi kubawi changed the title [VAULT-1324] Fix the CLI failing to return wrapping information for KV …PUTs and PATCHes when format is set to 'table' [VAULT-1324] Fix the CLI failing to return wrapping information for KV PUTs and PATCHes when format is set to 'table' Sep 6, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 6, 2023
@kubawi kubawi self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

CI Results:
All Go tests succeeded! ✅

@kubawi kubawi added this to the 1.13.7 milestone Sep 7, 2023
@kubawi kubawi marked this pull request as ready for review September 7, 2023 10:47
@kubawi kubawi requested a review from a team September 7, 2023 10:47
@kubawi kubawi added the core/cli label Sep 7, 2023
@kubawi kubawi changed the title [VAULT-1324] Fix the CLI failing to return wrapping information for KV PUTs and PATCHes when format is set to 'table' [VAULT-1324] Fix the CLI failing to return wrapping information for KV PUT and PATCH operations when format is set to 'table' Sep 7, 2023
kubawi
kubawi commented Sep 7, 2023
View reviewed changes
changelog/22818.txt Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Build Results:
All builds succeeded! ✅

@peteski22 @kubawi
Update changelog/22818.txt
eec82cc 
Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>
miagilepner
miagilepner reviewed Sep 7, 2023
View reviewed changes
command/kv_patch.go Outdated Show resolved Hide resolved
raskchanky
raskchanky reviewed Sep 7, 2023
View reviewed changes
command/kv_put.go Outdated Show resolved Hide resolved
kubawi and others added 2 commits September 7, 2023 20:20
@kubawi @peteski22
Update kv_patch.go
b80c733 
Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com>
@kubawi @peteski22
Update kv_put.go
989f9e9 
Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com>
@kubawi kubawi added backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` backport/1.13.x Backport changes to `release/1.13.x` labels Sep 7, 2023
@kubawi kubawi merged commit 3130e8b into main Sep 7, 2023
111 checks passed
@kubawi kubawi deleted the kubawi-peteski22/VAULT-1324/fix-control-group-wrapping branch September 7, 2023 19:43
This was referenced Sep 7, 2023
Merged
Merged
Merged
@kubawi kubawi modified the milestones: 1.13.7, 1.12.11 Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteski22 peteski22 peteski22 left review comments

@miagilepner miagilepner miagilepner left review comments

@raskchanky raskchanky raskchanky approved these changes

Assignees

@kubawi kubawi

Labels
backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` core/cli hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.12.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawi @raskchanky @peteski22 @miagilepner