Backport of reduce calls to DetermineRoleFromLoginRequest from 3 to 1 for aws auth method into release/1.12.x #22594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/reduce-role-resolves-part1/officially-frank-lemming
branch
from
ebfb9f7
to
a767ff6
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/reduce-role-resolves-part1/officially-frank-lemming
branch
from
a767ff6
to
ebfb9f7
Compare
|
|
elliesterner
force-pushed
the
backport/reduce-role-resolves-part1/officially-frank-lemming
branch
from
3e3f671
to
c14a926
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
mpalmi
approved these changes
Aug 29, 2023
…h method (#22583) * reduce calls to DetermineRoleFromLoginRequest from 3 to 1 for aws auth method * change ordering of LoginCreateToken args * replace another determineRoleFromLoginRequest function with role from context * add changelog * Check for role in context if not there make call to DeteremineRoleFromLoginRequest * move context role check below nanmespace check * Update changelog/22583.txt Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com> * revert signature to same order * make sure resp is last argument * retrieve role from context closer to where role variable is needed * remove failsafe for role in mfa login * Update changelog/22583.txt --------- Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
elliesterner
force-pushed
the
backport/reduce-role-resolves-part1/officially-frank-lemming
branch
from
c14a926
to
68fd29b
Compare
|
Build Results: |
elliesterner
deleted the
backport/reduce-role-resolves-part1/officially-frank-lemming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22583 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
🚨
The person who merged in the original PR is:
@elliesterner
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
The main purpose of this PR is to reduce calls to
c.DetermineRoleFromLoginRequestin order to reduce the latency of login requests.Benchmarking results:
Main
mean: 704.492117ms:Main with changes from PR
mean: 341.443427ms:Vault v1.10.4
mean: 180.187269ms:Overview of commits