Backport of Work around issue with UNIX domain sockets in api.Client addresses into release/1.14.x #22526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-api-client-unix-sockets/uniquely-mighty-scorpion
branch
from
264a862
to
39cc8f7
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-api-client-unix-sockets/uniquely-mighty-scorpion
branch
from
d9a2712
to
9e82f8d
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
ncabatoff
approved these changes
Aug 23, 2023
|
Build Results: |
ncabatoff
deleted the
backport/fix-api-client-unix-sockets/uniquely-mighty-scorpion
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22523 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
The Host part of the URL doesn't actually get used when we initiate connections to UNIX domain sockets. As of golang/go#60374 (in the latest Go releases at the time of this writing), we must set it to something that looks like a hostname or requests will fail.
Overview of commits