Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around issue with UNIX domain sockets in api.Client addresses #22523

Merged
merged 2 commits into from Aug 23, 2023
Merged

Work around issue with UNIX domain sockets in api.Client addresses #22523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77566cc
The Host part of the URL doesn't actually get used when we initiate c…
hc-github-team-secure-vault-core Aug 23, 2023
aa5e242
Add CL
hc-github-team-secure-vault-core Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/client.go
View file
Open in desktop
Expand Up @@ -545,7 +545,7 @@ func (c *Config) ParseAddress(address string) (*url.URL, error) {
// be pointing to the protocol used in the application layer and not to
// the transport layer. Hence, setting the fields accordingly.
u.Scheme = "http"
u.Host = socket
u.Host = "localhost"
u.Path = ""
} else {
return nil, fmt.Errorf("attempting to specify unix:// address with non-transport transport")
Expand Down
3 changes: 3 additions & 0 deletions changelog/22523.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
api: Fix breakage with UNIX domain socket addresses introduced by newest Go versions as a security fix.
```