Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on post-unseal funcs being run in any particular order. #22362

Merged
merged 3 commits into from Aug 16, 2023
Merged

Don't rely on post-unseal funcs being run in any particular order. #22362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba3f7f9
Don't rely on post-unseal funcs being run in any particular order.
hc-github-team-secure-vault-core Aug 16, 2023
1a6d961
Add CL
hc-github-team-secure-vault-core Aug 16, 2023
8042d43
Fix capture
hc-github-team-secure-vault-core Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
0 changelog/24170.txt → changelog/21470.txt
View file
Open in desktop
File renamed without changes.
3 changes: 3 additions & 0 deletions changelog/22362.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
core: Fix readonly errors that could occur while loading mounts/auths during unseal
```
7 changes: 3 additions & 4 deletions vault/auth.go
View file
Open in desktop
Expand Up @@ -798,10 +798,6 @@ func (c *Core) setupCredentials(ctx context.Context) error {
view.setReadOnlyErr(logical.ErrSetupReadOnly)
if strutil.StrListContains(singletonMounts, entry.Type) {
defer view.setReadOnlyErr(origViewReadOnlyErr)
} else {
c.postUnsealFuncs = append(c.postUnsealFuncs, func() {
view.setReadOnlyErr(origViewReadOnlyErr)
})
}

// Initialize the backend
Expand Down Expand Up @@ -914,6 +910,9 @@ func (c *Core) setupCredentials(ctx context.Context) error {
postUnsealLogger.Error("skipping initialization for nil auth backend")
return
}
if !strutil.StrListContains(singletonMounts, localEntry.Type) {
view.setReadOnlyErr(origViewReadOnlyErr)
}

err := backend.Initialize(ctx, &logical.InitializationRequest{Storage: view})
if err != nil {
Expand Down
7 changes: 3 additions & 4 deletions vault/mount.go
View file
Open in desktop
Expand Up @@ -1514,10 +1514,6 @@ func (c *Core) setupMounts(ctx context.Context) error {
view.setReadOnlyErr(logical.ErrSetupReadOnly)
if strutil.StrListContains(singletonMounts, entry.Type) {
defer view.setReadOnlyErr(origReadOnlyErr)
} else {
c.postUnsealFuncs = append(c.postUnsealFuncs, func() {
view.setReadOnlyErr(origReadOnlyErr)
})
}

var backend logical.Backend
Expand Down Expand Up @@ -1603,6 +1599,9 @@ func (c *Core) setupMounts(ctx context.Context) error {
postUnsealLogger.Error("skipping initialization for nil backend", "path", localEntry.Path)
return
}
if !strutil.StrListContains(singletonMounts, localEntry.Type) {
view.setReadOnlyErr(origReadOnlyErr)
}

err := backend.Initialize(ctx, &logical.InitializationRequest{Storage: view})
if err != nil {
Expand Down