Backport of Ignore errors from rollback manager invocations into release/1.12.x #22236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-log-not-err-on-rollback-failures/slightly-quick-gibbon
branch
from
4b8d478
to
03db5a1
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-log-not-err-on-rollback-failures/slightly-quick-gibbon
branch
from
03db5a1
to
4b8d478
Compare
|
|
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
* Ignore errors from rollback manager invocations During reload and mount move operations, we want to ensure that errors created by the final Rollback are not fatal (which risk failing replication in Enterprise when the core/mounts table gets invalidated). This mirrors the behavior of the periodic rollback manager, which only logs the error. This updates the noop backend to allow failing just rollback operations, which we can use in tests to verify this behavior and ensure the core operations (plugin reload, plugin move, and seal/unseal) are not broken by this. Note that most of these operations were asynchronous from the client's PoV and thus did not fail anyways prior to this change. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> * Add changelog entry Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> * Update vault/external_tests/router/router_ext_test.go Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com> --------- Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
cipherboy
force-pushed
the
backport/cipherboy-log-not-err-on-rollback-failures/slightly-quick-gibbon
branch
from
5908615
to
08f0731
Compare
…rollback-failures/slightly-quick-gibbon
cipherboy
approved these changes
Aug 16, 2023
|
Build Results: |
cipherboy
deleted the
backport/cipherboy-log-not-err-on-rollback-failures/slightly-quick-gibbon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22235 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
🚨
The person who merged in the original PR is:
@cipherboy
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
During reload and mount move operations, we want to ensure that errors created by the final Rollback are not fatal (which risk failing replication in Enterprise when the core/mounts table gets invalidated). This mirrors the behavior of the periodic rollback manager, which only logs the error.
This updates the noop backend to allow failing just rollback operations, which we can use in tests to verify this behavior and ensure the core operations (plugin reload, plugin move, and seal/unseal) are not broken by this. Note that most of these operations were asynchronous from the client's PoV and thus did not fail anyways prior to this change.
reg: VAULT-18857
Overview of commits