Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore errors from rollback manager invocations #22235

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Ignore errors from rollback manager invocations #22235

merged 3 commits into from
Aug 8, 2023

Commits on Aug 8, 2023

  1. Ignore errors from rollback manager invocations 

    During reload and mount move operations, we want to ensure that errors
created by the final Rollback are not fatal (which risk failing
replication in Enterprise when the core/mounts table gets invalidated).
This mirrors the behavior of the periodic rollback manager, which
only logs the error.

This updates the noop backend to allow failing just rollback operations,
which we can use in tests to verify this behavior and ensure the core
operations (plugin reload, plugin move, and seal/unseal) are not broken
by this. Note that most of these operations were asynchronous from the
client's PoV and thus did not fail anyways prior to this change.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    34d5772 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    bb1681c View commit details
    Browse the repository at this point in the history

  3. Update vault/external_tests/router/router_ext_test.go 

    Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
    @cipherboy @ncabatoff
    cipherboy and ncabatoff committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    3fb084b View commit details
    Browse the repository at this point in the history