Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Don't allow setting dead server last contact threshold to less than 1 minute into release/1.14.x #22058

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #22040 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


This is a frequent source of problems when people tune their autopilot configs. I took a quick pass over the other autopilot config values and didn't see any that screamed for validation quite as much as this one, but if there are others that people think should be validated for some valid range of values, I'm happy to add those.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/autopilot-config-validation/openly-wanted-lab branch from 84f18af to 3917da4 Compare July 26, 2023 00:10
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/autopilot-config-validation/openly-wanted-lab branch from 7cfc9fb to 5fb3b86 Compare July 26, 2023 00:10
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 26, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@raskchanky raskchanky merged commit 0343d04 into release/1.14.x Jul 26, 2023
87 of 88 checks passed
@raskchanky raskchanky deleted the backport/autopilot-config-validation/openly-wanted-lab branch July 26, 2023 00:27
@raskchanky raskchanky added this to the 1.14.2 milestone Jul 26, 2023
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants