Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix CSP warning on login #21673

Merged

Conversation

hashishaw
Copy link
Collaborator

Fixes a bug introduced in this backport where the form event on "doSubmit" in the login form was not prevented, which resulted in this console warning:

Refused to send form data to 'http://127.0.0.1:8200/ui/vault/auth?token=hellothere' because it violates the following Content Security Policy directive: "form-action 'none'".

This was fixed for 1.13 during the Ember Upgrade, but the bug was still present in 1.12.8.

@hashishaw hashishaw added ui bug Used to indicate a potential bug labels Jul 7, 2023
@hashishaw hashishaw added this to the 1.12.9 milestone Jul 7, 2023
@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 7, 2023
@hashishaw hashishaw merged commit 29ef853 into release/1.12.x Jul 11, 2023
10 checks passed
@hashishaw hashishaw deleted the ui/VAULT-17596/fix-csp-warning-on-login-1.12 branch July 11, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants