Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add Configurable LDAP Max Page Size into release/1.11.x #20281

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19032 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Resolves #18875

#17640 introduced paging into LDAP authentication. This is resulting in an issue where directories that do not permit paging are erroring out (see #18875). This change allows for a configurable option to see this manually (or disable it completely by setting the value to 0)


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 20, 2023

CLA assistant check
All committers have signed the CLA.

* Add config flag for LDAP max page size

* Add changelog

* move changelog to correct file

* cleanup

* Default to non-paged searching for with -1

* Update website/content/api-docs/auth/ldap.mdx

Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>

* Update website/content/docs/auth/ldap.mdx

Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>

* Update tests

---------

Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
@ltcarbonell ltcarbonell force-pushed the backport/GH-18875/partially-quiet-duckling branch from c750bb2 to 0c2a72b Compare April 20, 2023 21:01
@ltcarbonell ltcarbonell marked this pull request as ready for review April 20, 2023 21:04
@ltcarbonell ltcarbonell requested a review from a team April 20, 2023 21:04
@jasonodonnell jasonodonnell added this to the 1.11.10 milestone Apr 20, 2023
@ltcarbonell ltcarbonell merged commit 482afc2 into release/1.11.x Apr 20, 2023
79 checks passed
@ltcarbonell ltcarbonell deleted the backport/GH-18875/partially-quiet-duckling branch April 20, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants