Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade vault-plugin-auth-azure to v0.13.0 #19077

Merged
merged 4 commits into from Feb 8, 2023
Merged

upgrade vault-plugin-auth-azure to v0.13.0 #19077

merged 4 commits into from Feb 8, 2023

Conversation

vinay-gopalan
Copy link
Contributor

Upgrades the Auth Azure plugin to v0.13.0

Steps:

go get github.com/hashicorp/vault-plugin-auth-azure@v0.13.0
go mod tidy

@vinay-gopalan vinay-gopalan requested a review from a team February 8, 2023 20:22
vinay-gopalan
vinay-gopalan commented Feb 8, 2023
View reviewed changes
changelog/19077.txt Outdated
@@ -0,0 +1,6 @@
```release-note:feature
auth/azure: Adds support for rotate root to Azure Auth
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if I should list all the other features added or just the latest one. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if they are all being added to 1.13 and there's no previous changelog entry for them, it makes sense to add them all now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say list all of the features/improvements/fixes that are being brought in at this time. I'd say you can leave the dependency upgrade entry out of the Vault changelog though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is a specific format for "feature" changelog entries. I don't believe these conform to the format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the clarification, @austingebauer! Updated the changelog to match the desired format for multiple features

robmonte
robmonte approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@robmonte robmonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Zlaticanin
Zlaticanin approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vinay-gopalan vinay-gopalan merged commit cd54005 into main Feb 8, 2023
@vinay-gopalan vinay-gopalan deleted the update-auth-azure-v0.13.0 branch February 8, 2023 22:15
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@vinay-gopalan
upgrade vault-plugin-auth-azure to v0.13.0 (hashicorp#19077)
cc76ccd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlaticanin Zlaticanin Zlaticanin approved these changes

@austingebauer austingebauer Awaiting requested review from austingebauer

@robmonte robmonte Awaiting requested review from robmonte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vinay-gopalan @robmonte @austingebauer @Zlaticanin