Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cleanup ssh dynamic keys host keys #18939

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

cipherboy
Copy link
Contributor

This adds a new endpoint, tidy/dynamic-keys that removes any stale host keys still present on the mount. This does not clean up any pending dynamic key leases and will not remove these keys from systems with authorized hosts entries created by Vault.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>


Follow up to #18874.

This adds a new endpoint, tidy/dynamic-keys that removes any stale host
keys still present on the mount. This does not clean up any pending
dynamic key leases and will not remove these keys from systems with
authorized hosts entries created by Vault.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy added this to the 1.13.0-rc1 milestone Feb 1, 2023
@cipherboy cipherboy requested review from sgmiller, stevendpclark and a team February 1, 2023 14:14
@cipherboy cipherboy force-pushed the cipherboy-add-cleanup-ssh-dynamic-keys-host-keys branch from 2304bbb to 7544ce5 Compare February 1, 2023 14:15
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy force-pushed the cipherboy-add-cleanup-ssh-dynamic-keys-host-keys branch from 7544ce5 to fbf26f5 Compare February 1, 2023 14:42
@cipherboy cipherboy enabled auto-merge (squash) February 1, 2023 14:45
@cipherboy
Copy link
Contributor Author

Thanks!

@cipherboy cipherboy merged commit e4766aa into main Feb 1, 2023
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
* Add ability to clean up host keys for dynamic keys

This adds a new endpoint, tidy/dynamic-keys that removes any stale host
keys still present on the mount. This does not clean up any pending
dynamic key leases and will not remove these keys from systems with
authorized hosts entries created by Vault.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Add documentation

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

* Add changelog entry

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>

---------

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy cipherboy deleted the cipherboy-add-cleanup-ssh-dynamic-keys-host-keys branch April 21, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants