Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: PKI Sign Intermediate #18842

Merged
merged 22 commits into from Jan 27, 2023
Merged

UI: PKI Sign Intermediate #18842

merged 22 commits into from Jan 27, 2023

Conversation

hashishaw
Copy link
Collaborator

@hashishaw hashishaw commented Jan 25, 2023 •
edited

This is the final piece of work for PKI UI Beta for release in 1.13. It adds the page and form for the issuer sign intermediate action.

Issuer sign Intermediate

Previous related work:
#16925
#17054
#17134
#17210
#17236
#17239
#17263
#17393
#17609
#17613
#17875
#17927
#17997
#18069
#18087
#18113
#18146
#18194
#18229
#18268
#18300
#18343
#18349
#18381
#18387
#18412
#18545
#18490
#18495
#18496
#18504
#18563
#18599
#18634
#18639
#18687
#18695
#18712
#18717
#18737
#18744
#18760
#18761
#18781
#18782
#18791
#18807
#18845
#18847
#18867
#18867

@hashishaw hashishaw added this to the 1.13.0-rc1 milestone Jan 25, 2023
hellobontempo
hellobontempo reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work 🎉 I'm curious about the fetchCertByFormat in both the component and in the controller? Does this functionality apply to both downloading an issuer and the issued certificate (returned from the POST request to sign-intermediate)?

ui/lib/pki/addon/components/pki-sign-intermediate-form.hbs Outdated Show resolved Hide resolved
@hashishaw hashishaw force-pushed the ui/VAULT-9361/pki-issuer-sign-intermediate branch from 662e9a8 to 10e3dc1 Compare January 26, 2023 16:47
@hashishaw hashishaw marked this pull request as ready for review January 26, 2023 18:46
hellobontempo
hellobontempo approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close to the phase 1 finish line!! 🎉 Some small cleanup items, but nothing major. Approving in the interest of impending feature freeze 🥶

ui/app/adapters/pki/action.js Show resolved Hide resolved
ui/app/models/pki/issuer.js Outdated Show resolved Hide resolved
ui/app/models/pki/sign-intermediate.js Outdated Show resolved Hide resolved
ui/app/models/pki/sign-intermediate.js Show resolved Hide resolved
ui/lib/pki/addon/components/pki-generate-toggle-groups.ts Show resolved Hide resolved
ui/lib/pki/addon/components/page/pki-issuer-details.hbs Outdated Show resolved Hide resolved
ui/lib/pki/addon/components/page/pki-issuer-details.hbs Outdated Show resolved Hide resolved
ui/lib/pki/addon/components/page/pki-issuer-details.hbs Show resolved Hide resolved
ui/lib/pki/addon/templates/issuers/issuer/sign.hbs Outdated Show resolved Hide resolved
ui/tests/integration/components/pki-sign-intermediate-form-test.js Show resolved Hide resolved
hashishaw and others added 2 commits January 27, 2023 10:44
@hashishaw @hellobontempo
Links class
cd62686 
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
@hashishaw @hellobontempo
Link class update
9a7aaa2 
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
@hashishaw hashishaw enabled auto-merge (squash) January 27, 2023 17:23
@hashishaw hashishaw enabled auto-merge (squash) January 27, 2023 17:44
@hashishaw hashishaw merged commit 0b0d269 into main Jan 27, 2023
@hashishaw hashishaw deleted the ui/VAULT-9361/pki-issuer-sign-intermediate branch January 27, 2023 18:55
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@hashishaw
UI: PKI Sign Intermediate (hashicorp#18842)
40c6107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hashishaw @hellobontempo