Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* added the new redis parameter documentation #18752

Merged
merged 10 commits into from Jan 18, 2023
Merged

Conversation

maxcoulombe
Copy link
Contributor

@maxcoulombe maxcoulombe commented Jan 18, 2023

  • Changed username & password to access_key_id & secret_access_key since the parameter naming caused confusion. This has been reported by customers who had trouble setting up the plugin.
  • Username & password are still supported for backward compatibility.
  • Provided a IAM policy sample that the Vault role requires to manage users, this has also caused friction to some users.
  • Various minor spelling corrections

Question: Should I only add the changelog when the plugin gets updated for Vault 1.13 release?

Docs
redis_doc

Api-Docs
redi_api-docs

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor formatting suggestions

maxcoulombe and others added 5 commits January 18, 2023 15:10
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
maxcoulombe and others added 2 commits January 18, 2023 15:10
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
@maxcoulombe maxcoulombe merged commit afac0f7 into main Jan 18, 2023
@maxcoulombe maxcoulombe deleted the vault-12648-RedisParamDoc branch January 18, 2023 20:51
dhuckins pushed a commit that referenced this pull request Jan 19, 2023
* added the new redis parameter documentation
* added changelog
dhuckins pushed a commit that referenced this pull request Jan 19, 2023
* added the new redis parameter documentation
* added changelog
@@ -0,0 +1,3 @@
```release-note:improvement
**Redis ElastiCache DB Engine**: Renamed configuration parameters for disambiguation; old parameters still supported for compatibility.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxcoulombe - with this formatting, this should be a "feature" not "improvement". Could you please update this file so that it's generated correctly for the 1.13 release? Thanks!

jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
* added the new redis parameter documentation
* added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants