Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: fixes link from to show page from entity policies list #17950

Merged
merged 4 commits into from Nov 16, 2022
Merged

UI: fixes link from to show page from entity policies list #17950

merged 4 commits into from Nov 16, 2022

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Nov 15, 2022 •
edited

this PR previously addressed a capabilities issue in the show template, but we decided to approach the solution another day and get to the root of the problem (rather than supply a bandaid fix)

@hellobontempo hellobontempo added this to the 1.13.0-rc1 milestone Nov 15, 2022
zofskeez
zofskeez previously approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder how this worked in the first place if the model was being unloaded on route change by that mixin? Maybe something changed in the run loop timing or something in the new version.

@zofskeez
Copy link
Contributor

A few policy tests are failing but I'm guessing they just need to be updated to have this.capabilities.isLoaded returning true.

@hellobontempo
Copy link
Contributor Author

hellobontempo commented Nov 16, 2022 •
edited

A few policy tests are failing but I'm guessing they just need to be updated to have this.capabilities.isLoaded returning true.

It ended up being more complicated than that...updated the template so that tests pass.

I'm not sure if changing the capabilities check from this.capabilities.canDelete to this.model.canDelete etc has far-reaching consequences? The capability model seemed to be what was causing the problem...

@zofskeez zofskeez self-requested a review November 16, 2022 01:47
@zofskeez zofskeez dismissed their stale review November 16, 2022 01:47

Reviewing new changes

zofskeez
zofskeez reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the capabilities model but it looks to me like using lazyCapabilities on the policy model itself is more appropriate. It might be a good idea to get another set of eyes on this just to be sure.

@hellobontempo hellobontempo modified the milestones: 1.13.0-rc1, 1.10.9 Nov 16, 2022
@hellobontempo hellobontempo changed the title UI: fixes accessing updatePath in template before model is loaded UI: fixes link from to show page from entity policies list Nov 16, 2022
@hellobontempo hellobontempo enabled auto-merge (squash) November 16, 2022 17:41
@hellobontempo hellobontempo merged commit 4e1958c into main Nov 16, 2022
This was referenced Nov 16, 2022
Closed
Merged
Merged
@hellobontempo hellobontempo deleted the ui/fix-entity-policy-show-page branch November 16, 2022 21:28
@hellobontempo hellobontempo mentioned this pull request Nov 16, 2022
Merged
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@hellobontempo
UI: fixes link from to show page from entity policies list (hashicorp…
30b72d0 
…#17950)

* wait for policy capabilities to load

* add changelog

* fix tests

* revert template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez left review comments

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.10.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hellobontempo @zofskeez @hashishaw