plugins: Filter builtins by RunningVersion #17816
Merged
+125
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
reviewed
Nov 4, 2022
|
Is there a test we could write to validate the old behaviour is fixed in a proportionate amount of effort? |
Absolutely will want to add some go tests to this. Thanks for the reminder! |
This commit adds some logic to handle the case where a mount entry has a non-builtin RunningVersion. This ensures that we only report deprecation status for builtins. This resolves VAULT-9019.
mpalmi
force-pushed
the
set-deprecation-status-on-mount
branch
from
364fdb0
to
266d883
Compare
mpalmi
changed the title
raskchanky
reviewed
Nov 11, 2022
raskchanky
approved these changes
Nov 11, 2022
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
This commit adds some logic to handle the case where a mount entry has a non-builtin RunningVersion. This ensures that we only report deprecation status for builtins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only update the status on mount and secrets/auth enable. This should resolve VAULT-9019.