core: fix start up policy loading race condition on perf standbys #17801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
requested review from
raskchanky,
briankassouf,
ncabatoff and
mpalmi
ncabatoff
reviewed
Nov 3, 2022
ncabatoff
approved these changes
Nov 3, 2022
briankassouf
approved these changes
Nov 3, 2022
This was referenced Nov 3, 2022
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
…shicorp#17801) * core: fix start up policy loading race condition on perf standbys * Use correct bool for perf standby * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a start up race condition where recently assigned performance standbys might not yet have received logs from the active node containing policies. This can sometimes result in a mount loop on the performance standbys and would only be fixed by restarting the performance standbys. The fix simply skips performance standbys all together.