Backport of Raft Snapshot Download Bug into release/1.12.x #17782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-7701/raft-snapshot-download-bug/badly-equal-liger
branch
from
f054d1e
to
1f79b47
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
* moves service worker message event listener from addon to raft-storage-overview component * adds changelog entry * adds raft-storage-overview test for downloading snapshot via service worker
…ot-download-bug/badly-equal-liger
|
Opening manual backport #17787 |
zofskeez
deleted the
backport/ui/VAULT-7701/raft-snapshot-download-bug/badly-equal-liger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17769 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
An uncaught error was causing the service worker to hang when attempting to download a raft snapshot which would eventually result in a permission denied response since the token was not provided to the fetch request.
In the
service-worker-authenticated-downloadin-repo addon theservice-worker-registrationis attempting to import from@ember/application/namespace. In the generatedsw-registration.jsscript this results in that module being accessed from theEmberglobal which has been removed and is undefined.Screencast.from.2022-11-01.03.27.11.PM.webm
This seems to be an issue with
ember-auto-import(or babel or webpack by extension) but I just couldn't figure out how to get that import working. I decided to move the event listener to theraft-storage-overviewcomponent in the parent application which is already doing a check for the service worker registration and where the download action lives.Overview of commits