Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix kv -mount flag error when mount and secret path are the same into release/1.11.x #17758

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17679 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

The below text is copied from the body of the original PR.


Using the -mount flag with kv subcommands fails with the following error when the mount and secret paths are the same:

❯ vault kv get -mount=secret secret

WARNING! The following warnings were returned from Vault:

  * Non-listing operations on the root of a K/V v2 mount are not supported.

== Secret Path ==
secret/data

The fix results in basically the same change across many files. Given the distributed nature of the logic it could benefit from some refactoring but fixing the issue first and introducing some consolidation of logic at a later date if we determine that's prudent seemed safer.

Fixes #17576
Fixes #16639


Overview of commits

@ccapurso ccapurso merged commit 318f893 into release/1.11.x Nov 1, 2022
@ccapurso ccapurso deleted the backport/fix-iss-17576/early-improved-tadpole branch November 1, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants