Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flag and env var which will disable client redirection #17352

Merged
merged 10 commits into from Sep 30, 2022
Merged

Added flag and env var which will disable client redirection #17352

merged 10 commits into from Sep 30, 2022

Conversation

peteski22
Copy link
Contributor

No description provided.

@peteski22 peteski22 self-assigned this Sep 28, 2022
@peteski22 peteski22 marked this pull request as ready for review September 29, 2022 18:28
peteski22 and others added 2 commits September 29, 2022 20:48
@peteski22 @taoism4504
Update website/content/docs/commands/index.mdx
6c3a469 
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
@peteski22 @taoism4504
Update website/content/docs/commands/index.mdx
2d52c15 
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
ccapurso
ccapurso approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peteski22 peteski22 merged commit 06c0c6c into main Sep 30, 2022
@peteski22 peteski22 deleted the VAULT-6995/ssrf-disable-client-redirect-option branch September 30, 2022 08:29
Merged
@mr-karan mr-karan mentioned this pull request Nov 23, 2022
Closed
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@peteski22
Added flag and env var which will disable client redirection (hashico…
1a7bd0b 
…rp#17352)

* Added flag and env var which will disable client redirection

* Added changelog

* Docs fix for unsaved file, and test single request made

* Updated test for case when redirect is enabled, updated docs based on suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccapurso ccapurso ccapurso approved these changes

@ncabatoff ncabatoff ncabatoff approved these changes

@taoism4504 taoism4504 taoism4504 approved these changes

Assignees

@peteski22 peteski22

Labels
core/client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peteski22 @ccapurso @ncabatoff @taoism4504 @mickael-hc