Return errInvalidCredentials when wrong credentials is provided for existent users #17104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the |
It is for approle, userpass and ldap |
HridoyRoy
approved these changes
Sep 13, 2022
mpalmi
approved these changes
Sep 13, 2022
ncabatoff
approved these changes
Sep 14, 2022
raskchanky
approved these changes
Sep 15, 2022
ncabatoff
approved these changes
Sep 16, 2022
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
…xistent users (hashicorp#17104) * adding errInvalidCredentials * fixing tests * add changelog * fixing fmt errors * test if routeErr is seen externally and fixing error comment * adding fmt changes * adding comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hashicorp.atlassian.net/browse/VAULT-8304
The auth methods returns a specific error code “ErrInvalidCredentials” in cases where it fails due to invalid credentials for existent users.
This helps to differentiate between existent and not existent users when lockout feature is implemented to prevent brute forcing
This is only used for handling lockouts and will be removed before return. This will not be returned or seen externally.
These changes are for approle, ldap and userpass auth methods
Added changes to RespondErrorCommon and also added a test to confirm that ErrInvalidCredentials is not seen externally.