postgres: replace the package lib/pq with pgx #15343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
changed the title
swenson
reviewed
May 20, 2022
fairclothjm
reviewed
May 20, 2022
calvn
reviewed
May 23, 2022
fairclothjm
approved these changes
May 23, 2022
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
* WIP replacing lib/pq * change timezome param to be URI format * add changelog * add changelog for redshift * update changelog * add test for DSN style connection string * more parseurl and quoteidentify to sdk; include copyright and license * call dbutil.ParseURL instead, fix import ordering Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib/pq package has been in maintenance mode for a while now which means that the package will not be receiving updates aside from bug fixes. The package does not support the ability to set multi-host on the connection string, which is a feature that has been requested by our users and customers. We will be swapping out this library with jackc/pgx which is being actively maintained and supports multi-host.
This PR will focus on transitioning our imports, and a separate PR will tackle multi-host support.
These are the following places affected by this import change:
builtin/postgres(deprecated engine)database/postgresdatabase/redshiftphysical/cockroachdbphysical/postgres