Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hashicorp/consul-template dependency #15092

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Apr 19, 2022

  • Includes sprig template functions
  • Includes improvements to writeTo template function
  • Adds new test case for sprig functions and slightly improves the error reporting when the test fails

* Includes sprig template functions
* Includes improvements to writeTo template function
@tomhjp tomhjp requested review from swenson, tvoran, calvn and a team April 19, 2022 15:26
@kalafut kalafut added this to the 1.10.1 milestone Apr 19, 2022
Copy link
Member

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test against sprig!

@tvoran
Copy link
Member

tvoran commented Apr 19, 2022

Looks like the tests are failing because TemplateConfig.Command is no longer a string?

Command: pointerutil.StringPtr("restart service foo"),

And apparently Command is deprecated in favor of Exec now.

@tvoran
Copy link
Member

tvoran commented Apr 19, 2022

Looks like we should check for Exec in those tests, something like:

Edit, nevermind, something like this seems to work:

Command:        []string{"restart service foo"}

@tomhjp tomhjp merged commit cf6004f into main Apr 19, 2022
@tomhjp tomhjp deleted the update-consul-template-0-28-2 branch April 19, 2022 19:51
kitography pushed a commit that referenced this pull request Apr 24, 2022
* Includes sprig template functions
* Includes improvements to writeTo template function
* Add sprig functions test, improve failure message
schultz-is pushed a commit that referenced this pull request Apr 27, 2022
* Includes sprig template functions
* Includes improvements to writeTo template function
* Add sprig functions test, improve failure message
schultz-is pushed a commit that referenced this pull request May 2, 2022
* Includes sprig template functions
* Includes improvements to writeTo template function
* Add sprig functions test, improve failure message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants