Parallel retry join #13606
Merged
Parallel retry join #13606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmmukh
approved these changes
Jan 13, 2022
joatmon08
pushed a commit
that referenced
this pull request
Jan 25, 2022
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using retry_join stanzas to setup new raft nodes via config (instead of issuing explicit join requests), each of the "leaders" specified are tried in turn until one if found that works, with a 2s delay between each attempt. It's common when using retry_join to use the same config that lists all nodes for every node's HCL, which means a new node could take quite a while to join if the actual leader in the cluster is listed last.
This PR changes how retry_join is handled so that we reach out to every node listed in parallel, and try to complete the join to the first node that replies without an error. We maintain the current behaviour of a 2s delay between each attempt, only now it's a 2s delay between retrying all nodes, instead of a 2s delay between each node attempt.