KV automatic delete state issue in UI #13166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cached values for deleted prop
zofskeez
commented
Nov 16, 2021
…version action when users cannot read metadata
Monkeychip
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Well done 👏 Thanks for taking all the extra steps here too! Oh, don't forget the labels too. UI and not sure if this is getting backported or not. Sounds like something that should be backported to 1.9 which is where the KV work was done. If you backport farther than that you might hit a lot of changes that make this merge difficult.
zofskeez
added a commit
that referenced
this pull request
Nov 23, 2021
* converts secret-v2-version model to native class -- fixes issues with cached values for deleted prop * adds changelog entry * adds disabled state to ToolbarLink component and disables create new version action when users cannot read metadata * updates secret-edit acceptance test
zofskeez
added a commit
that referenced
this pull request
Nov 23, 2021
* converts secret-v2-version model to native class -- fixes issues with cached values for deleted prop * adds changelog entry * adds disabled state to ToolbarLink component and disables create new version action when users cannot read metadata * updates secret-edit acceptance test
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* converts secret-v2-version model to native class -- fixes issues with cached values for deleted prop * adds changelog entry * adds disabled state to ToolbarLink component and disables create new version action when users cannot read metadata * updates secret-edit acceptance test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an automatic deletion time for a secret passes during a UI session the state was not properly updating to reflect the change. Instead of displaying the placeholder to indicate that the version has been deleted the secret is displayed with missing data.
The secret-edit route is fetching the version data but since the
deletionTimedoes not change thedeletedcomputed property on the secret-v2-version model was returning the cached value. After converting the model to a native class and using a getter the deleted value is calculated each time it is accessed which fixes the state issue.To test:
vault kv put secret/testversions key="value" && vault kv metadata put -delete-version-after="30s" secret/testversionsI started working on an acceptance test but since we are dealing with time elapsing I became concerned that it might end up flaky. If we think it's important to cover this case I'm happy to work on it more.