Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read support to sys/mounts/:path #12792

Merged
merged 4 commits into from Nov 8, 2021

Conversation

remilapeyre
Copy link
Contributor

Closes #12349

@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 19:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 19:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 20:41 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 20:41 Inactive
Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsimon-hashicorp hsimon-hashicorp merged commit 50adc3c into hashicorp:main Nov 8, 2021
hsimon-hashicorp pushed a commit that referenced this pull request Nov 8, 2021
* Add read support to sys/mounts/:path

Closes #12349

* Add changelog entry

* Empty commit to trigger CI

* Empty commit to trigger CI
@vsevel
Copy link

vsevel commented Nov 8, 2021

excellent! @hsimon-hashicorp what version will it go in?
cc @kdubb

@@ -0,0 +1,3 @@
```release-note: feature
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsimon-hashicorp we use a special changelog format for new features (it's outlined on the wiki). I think this is more of an improvement though, so I've moved it and I'm going to tag you on an enterprise PR.

qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
* Add read support to sys/mounts/:path

Closes hashicorp#12349

* Add changelog entry

* Empty commit to trigger CI

* Empty commit to trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/sys/mounts/:path/tune should return the engine type
6 participants