fix secrets stored in json format #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
force-pushed
the
VAULT-1818/jsonformat
branch
3 times, most recently
from
a850752
to
ff534fd
Compare
fairclothjm
force-pushed
the
VAULT-1818/jsonformat
branch
from
ff534fd
to
10ed439
Compare
fairclothjm
changed the title
robmonte
reviewed
Jun 20, 2023
robmonte
approved these changes
Jun 21, 2023
austingebauer
approved these changes
Jun 21, 2023
Comment on lines
+101
to
+102
| // This is required to support secrets in JSON format. | ||
| // See https://github.com/hashicorp/vault-action/issues/194 and https://github.com/hashicorp/vault-action/pull/173 |
There was a problem hiding this comment.
Thanks for adding these comments!
There was a problem hiding this comment.
No problem! Hopefully it will save someone all the time it took me to understand what is happening in this code :)
fairclothjm
added a commit
that referenced
this pull request
Jul 3, 2023
This reverts commit b9f4d16.
fairclothjm
added a commit
that referenced
this pull request
Jul 3, 2023
This reverts commit b9f4d16.
fairclothjm
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke support for secrets in JSON format in #173. This adds that support back and also adds a few tests to ensure we can catch any regressions moving forward.
Additionally, we add some improvements to the local-test job that we run with the act CLI. Namely, it is no longer required to push up a branch with the local changes but instead act will use build and run the local src files as-is.
Closes #194