Update HCL #33758
Merged
Update HCL #33758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update incorporates fixes to `try` and `can` to better handle unknown arguments.
jbardin
force-pushed
the
jbardin/update-hcl
branch
from
c562996
to
856799f
Compare
apparentlymart
approved these changes
Aug 25, 2023
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update incorporates fixes to
tryandcanto better handle unknown arguments, see hashicorp/hcl#622 for more details.Pinning HCL to a commit in case there are more changes during testing. An HCL v2.17.1 release should be cut before the final Terraform release.
Fixes #33659
Fixes #31646
While this does resolve many similar cases to #31868 as well, the example there cannot be solved yet as shown. More detailed refinement from
trycould be done in the future (even if it's not possible to solve all cases), so we can leave that issue open for tracking purposes.