Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go-cty to v1.13.3 #33741

Merged
merged 1 commit into from
Aug 25, 2023
Merged

upgrade go-cty to v1.13.3 #33741

merged 1 commit into from
Aug 25, 2023

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Aug 24, 2023

Fixes #33464 a little closer to the root.
hashicorp/hcl#616 fixes the effect of this in HCL templates (there is no HCL release as yet).

Changelog for cty 1.13.3:

  • msgpack: As a compromise to avoid unbounded memory usage for a situation that some callers won't take advantage of anyway, the MessagePack decoder has a maximum length limit on encoded unknown value refinements. For consistency, the encoder will now truncate string prefix refinements if necessary to avoid making the encoded refinements too long. (#167)
    This is consistent with the documented conventions for serializing refinements -- that we can potentially lose detail through serialization -- but in this case we are still able to preserve shorter string prefixes, whereas other serializations tend to just discard refinement information altogether.

@kmoe kmoe merged commit 14dacd7 into main Aug 25, 2023
6 checks passed
@kmoe kmoe deleted the cty-1.13.3 branch August 25, 2023 10:11
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when a refined unknown string has too long a prefix
2 participants