Backport of always evaluate module outputs during destroy into v1.5

[teamterraform]

Backport

This PR is auto-generated from #33462 to be assessed for backporting due to the inclusion of the label 1.5-backport.

The below text is copied from the body of the original PR.

---

A module output is generally not used during destroy, however it must be evaluated when its value is used by a provider for configuration, because that configuration is not stored between walks.

There was an oversight in the output expansion node where the output node was not created because the operation was destroy, and module outputs have nothing to destroy. This however skipped evaluation when the output is needed by a provider as mentioned above. Because of the way an implied plan is stored internally when executing terraform destroy, this went unnoticed by the test.

Allowing the output to be evaluated during destroy fixes the issue, and should be acceptable because an output is classified as temporary in the graph, and will be pruned when not actually needed.

Update the existing test to serialize the plan, which triggers the failure.

Fixes #33455

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.