Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multierror.Append instead of append #33459

Merged
merged 1 commit into from
Jun 30, 2023
Merged

use multierror.Append instead of append #33459

merged 1 commit into from
Jun 30, 2023

Conversation

alisdair
Copy link
Member

1.5 backport of #33108. Original PR description:


Ran into this error while running terraform inside a container, after it applied my plans, terraform failed saving state to Consul. I suspect my policy needs tweaking, but it's near impossible to tell with an error like this:

╷
│ Error: Failed to save state
│ 
│ Error saving state: consul CAS failed with transaction errors:
│ [0xc0006e93c8]
╵

This PR changes the the rendering of the error instance to actually print the message, instead of the memory address of said error instance.

Target Release

1.5.x

Draft CHANGELOG entry

BUG FIXES

  • When using consul as a state backend and failing to save state, consul CAS failed with transaction errors no longer shows an error instance memory address but an actual error message.

Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com>
@alisdair alisdair requested a review from a team as a code owner June 30, 2023 13:54
@alisdair alisdair self-assigned this Jun 30, 2023
@alisdair alisdair merged commit a8491a1 into v1.5 Jun 30, 2023
8 checks passed
@alisdair alisdair deleted the backport-33108 branch June 30, 2023 14:03
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants