-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify types and link to Type Constraints pagedit types #33132
Conversation
Thanks for this submission! I have notified the docs team. |
Should I continue to leave this PR open? There hasn't been any activity in several months. |
I think the docs team is a little backed up. Let me check in with them. |
Co-authored-by: Judith Malnick <judith@hashicorp.com>
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@judithpatudith, there's some confusion about type specifics here, should we roll this back or rewrite it?
* `map` (or `object`): a group of values identified by named labels, like | ||
* `list`: a sequence of values, like `["us-west-1a", "us-west-1c"]`. Identify elements in a list with consecutive whole numbers, starting with zero. | ||
* `set`: a collection of unique values that do not have any secondary identifiers or ordering. | ||
* `map`: a group of values identified by named labels, like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object
was removed from the definition here, but the example is an object
and not a map
`{name = "Mabel", age = 52}`. | ||
|
||
Strings, numbers, and bools are sometimes called _primitive types._ Lists/tuples and maps/objects are sometimes called _complex types,_ _structural types,_ or _collection types._ | ||
Strings, numbers, and bools are sometimes called _primitive types._ Lists and sets are forms | ||
of tuples. Maps are a form of objects. Tuples and objects are sometimes called _complex types,_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list
and set
are not forms of tuple
, though homogeneous tuples can be converted to and from lists, and sets are unordered.
@jbardin great catch, sorry about that! I'd say overwrite it; do you have time to open the PR? |
We will want to backport the fix into 1.5 and 1.6 branches, just FYI. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
set
to the types list on thetypes.mdx
page.Note: this definition of
set
is copied from the Type Constraints page, though that language may not be clear in this context. Rather than risk making a technical error, I opted to stay with the same text.Target Release
1.4.x
Draft CHANGELOG entry
N/A