Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QoL: Run acceptance tests against all the current minor versions of Terraform >= 0.12 #153

Merged
merged 3 commits into from
Feb 22, 2022
Merged

QoL: Run acceptance tests against all the current minor versions of Terraform >= 0.12 #153

merged 3 commits into from
Feb 22, 2022
+96 −80

Conversation

detro
Copy link
Contributor

@detro detro commented Feb 21, 2022 •
edited
Loading

@detro detro requested a review from a team as a code owner February 21, 2022 19:26
@github-actions github-actions bot added size/M and removed size/XS labels Feb 21, 2022
bflad
bflad approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one thing to possibly consider. 🚀

.github/workflows/test.yml Outdated
- '0.12.30'
- '0.13.6'
- '0.14.5'
- '0.12.31'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If we switch to using the hashicorp/setup-terraform@v1 action instead of TF_ACC_TERRAFORM_VERSION environment variable we can install the latest patch versions. Refer to terraform-provider-corner for an example. 😄

Copy link
Contributor Author

@detro detro Feb 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, actually I have seen your PR yesterday and I think we should do the switch.

Having the flexibility to test against the latest patch and not having to manually maintain this list is the best way.

Will update this PR.

@bryantbiggs
Copy link

FYI - I think this PR will also close #127

@detro
Copy link
Contributor Author

detro commented Feb 22, 2022

Thank you @bryantbiggs - I looked up but I couldn't find a PR or issue that described this issue.

I'll apply the changes suggested by @bflad and will link and close that one.

Moving from using the SDK internal TF_ACC_TERRAFORM_VERSION install…
2bcd0e3 
…er, to the `hashicorp/setup-terraform@v1` GH Action
@github-actions github-actions bot added size/L and removed size/M labels Feb 22, 2022
@detro detro merged commit 03ac026 into main Feb 22, 2022
@detro detro deleted the detro/QoL-test_against_all_tf branch February 22, 2022 17:14
@detro detro changed the title Run acceptance tests against all the current minor versions of Terraform >= 0.12 QoL: Run acceptance tests against all the current minor versions of Terraform >= 0.12 Feb 24, 2022
@detro detro added github_actions Pull requests that update Github_actions code go Pull requests that update Go code QoL Quality of Life labels Feb 24, 2022
@detro
Copy link
Contributor Author

detro commented Mar 11, 2022

Closes #140

@detro detro mentioned this pull request Mar 11, 2022
Closed
@detro detro added this to the v3.2.0 milestone Mar 16, 2022
@detro detro self-assigned this Mar 30, 2022
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad

Assignees

@detro detro

Labels
github_actions Pull requests that update Github_actions code go Pull requests that update Go code QoL Quality of Life size/L
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@detro @bryantbiggs @bflad