Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SchemaConfigModeAttr #19207

Conversation

modular-magician
Copy link
Collaborator

fixes #12824

Compute subnetwork preparation change: GoogleCloudPlatform/magic-modules#11410
Guest Accelerator preparation change: GoogleCloudPlatform/magic-modules#11425

Composer's ip_allocation_policy did not actually send an empty list when specifying an empty block, and it is create-only. Therefore removing configModeAttr doesn't make a difference

google_compute_instance_from_template and google_compute_instance_from_machine_image functionality for empty blocks is being removed to prevent accidental breaking changes for new subfields from the parent google_compute_instance

Release Note Template for Downstream PRs (will be copied)

composer: `ip_allocation_policy = []` in `google_composer_environment` is no longer valid configuration. Removing the field from configuration should not produce a diff.
compute: `secondary_ip_ranges = []` in `google_compute_subnetwork` is no longer valid configuration. To set an explicitly empty list, use `send_secondary_ip_range_if_empty` and completely remove `secondary_ip_range` from config.
compute: `guest_accelerator = []` is no longer valid configuration in `google_compute_instance`. To explicitly set an empty list of objects, set guest_accelerator.count = 0.
compute: `google_compute_instance_from_template` and `google_compute_instance_from_machine_image` `network_interface.alias_ip_range, network_interface.access_config, attached_disk, guest_accelerator, service_account, scratch_disk` can no longer be set to an empty block `[]`. Removing the fields from configuration should not produce a diff.
container: `guest_accelerator = []` is no longer valid configuration in `google_container_cluster` and `google_container_node_pool`. To explicitly set an empty list of objects, set guest_accelerator.count = 0.
container: `guest_accelerator.gpu_driver_installation_config = []` and `guest_accelerator.gpu_sharing_config = []` are no longer valid configuration in `google_container_cluster` and `google_container_node_pool`. Removing the fields from configuration should not produce a diff.

Derived from GoogleCloudPlatform/magic-modules#11506

[upstream:93bcf85b934cdfdc5d45ae2f876118ab8dd8d3e9]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 301eeab into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Aug 21, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
@modular-magician modular-magician deleted the downstream-pr-93bcf85b934cdfdc5d45ae2f876118ab8dd8d3e9 branch November 17, 2024 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant