Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relay_mode field support #19060

Conversation

modular-magician
Copy link
Collaborator

fixes #17997

relay_mode field from AdvancedDatapathObservabilityConfig is superseded by enable_relay field and will be deprecated on the provider side in near future.

This is a breaking change according to TF docs and as such, should be released in the next major release. Deprecation of relay_mode field on TF side has already happened more than a month ago, foreshadowing this change through deprecation message.

This field is part of a provider feature that is still in Public Preview and yet to go GA.

container: removed deprecated field `advanced_datapath_observability_config.relay_mode` from `google_container_cluster` resource. Users are expected to use `enable_relay` field instead.
container: made field `advanced_datapath_observability_config.enable_relay` required in `google_container_cluster` resource

Derived from GoogleCloudPlatform/magic-modules#10274

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Michal Siwinski <siwy@google.com>

[upstream:4f39da51c0464ab867e96abba3168d78841a86e1]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 542972b into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Aug 9, 2024
3 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
@modular-magician modular-magician deleted the downstream-pr-4f39da51c0464ab867e96abba3168d78841a86e1 branch November 17, 2024 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant