Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for apphub discovered service #17548

Conversation

modular-magician
Copy link
Collaborator

Add data source for apphub discovered service to automate querying and facilitate its use while registering service.
FIXES #17471

Based on other PRs:
GoogleCloudPlatform/magic-modules#10079
GoogleCloudPlatform/magic-modules#10048
GoogleCloudPlatform/magic-modules#10152

Release Note Template for Downstream PRs (will be copied)

`google_apphub_discovered_service`

Derived from GoogleCloudPlatform/magic-modules#10105

* Add data source for apphub discovered service

* Add data source for apphub discovered service'

* Add data source for apphub discovered service

* resolved comments

* retry logic added

* add tests and documentation

* Corrected tests and added project field in the data source

* changed id field

* Added random_suffix for the resources created and enabled iam policy and compute api

* modified retry logic

* Modified schema for the data source, and tests

* Removed IAM permission blocks

* Add dependency for compute api

* Resolve merge conflict

* Add time sleep

* Modified test function name

* Shorten service project name

* Add billing account

* corrected get env variable function call

* Modified project id

* Combined time delay

* Resolving comments

* Remove retry logic and add time sleep for resource ingestion

[upstream:922cc703a5cc9d371a1396bec930869be9d890e9]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 4da62e7 into hashicorp:main Mar 12, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New data source for Discovered Service in App Hub
1 participant