Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings.data_cache_config permadiff when set to false #8889

Conversation

modular-magician
Copy link
Collaborator

When settings.data_cache_config false a permadiff will result. This is due to the fact that CloudSQL API will not return data_cache_config when there is no data cache. Update terraform to match CloudSQL API by representing non existent data cache config as set to false .

Mentioned in:
hashicorp/terraform-provider-google#15227
hashicorp/terraform-provider-google#19144

Release Note Template for Downstream PRs (will be copied)

sql: fixed permadiff when 'settings.data_cache_config' is set to false for 'google_sql_database_instance' resource

Derived from GoogleCloudPlatform/magic-modules#12496

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[upstream:2936c3ba867221c9bfcdeb2a82b5542b0da91897]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 10, 2024 21:12
@modular-magician modular-magician merged commit d408dc5 into hashicorp:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant