Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform support for Workbench instances #6739

Conversation

modular-magician
Copy link
Collaborator

Description: Support for Workbench instances
Fixes hashicorp/terraform-provider-google#16336

Release Note Template for Downstream PRs (will be copied)

google_workbench_instance
google_workbench_instance_iam_*

Derived from GoogleCloudPlatform/magic-modules#9368

Verified

This commit was signed with the committer’s verified signature.
wojtekmaj Wojciech Maj
* Workbench Instances

* fix yaml to run tests

* fix yaml to run tests

* fix basic test

* diff suppress for tags

* add custom flattens

* Add labels example

* fix tags diff

* custom_flatten with ignore_read

* removed ignore_read

* remove ignore_read on disks

* Add kms key in full test

* read_ignore for examples

* clean up extra flattens

* add update test

* fix indent lint

* fix wbi lint

* fix lint issues

* fix whitespace

* change names in full test to vars

* change tests to use variable names instead of hard coded values

* stop wbi before updating machine_type

* all tests passing

* fix terraformgoogleconversion-codegen compiler error

* make service account immutable

* addressed issues with immutable fields

* add disable_proxy_access into full example

* Add disable_proxy_access in full test

* remove returns in pre and post updates

* test false values in secure vm config

* fix empty shielded instance config

* fixed update on non stop needing fields failing

* create custom update mask

* make disks sub fields completely immutable

* update tests for shielded config and gpu driver

* Removed scopes block from product

* removed apis required

* break shielded_instance_config update msk into submasks

* revert update mask for shieldedInstanceConfig

* Make vm image immutable

* Remove gpu driver config

* remove shielded instance config field

* removed unspecified values in enums

* reupload

* removed max_items in serviceAccounts
[upstream:c2f6cc6bfdc7c160de0eb36c9b9c9e6f151d8bba]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 24ef00c into hashicorp:main Dec 11, 2023
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-c2f6cc6bfdc7c160de0eb36c9b9c9e6f151d8bba branch November 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertex Workbench Instance
1 participant