Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer v2 (beta) (#9611) #3709

Conversation

modular-magician
Copy link
Collaborator

Add support for creation of Cloud Composer v2 environments.

fixes hashicorp/terraform-provider-google/issues/9611

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

composer: added support for composer v2 fields `workloads_config` and `cloud_composer_network_ipv4_cidr_block` to `composer_environment`

Derived from GoogleCloudPlatform/magic-modules#5181

Sorry, something went wrong.

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Goran Obradovic <gobradovic@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 3c5a520 into hashicorp:master Oct 6, 2021
nat-henderson pushed a commit that referenced this pull request Oct 7, 2021
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Goran Obradovic <gobradovic@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Goran Obradovic <gobradovic@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
megan07 pushed a commit that referenced this pull request Oct 11, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* changelog for 3.88.

* Composer v2 (beta) (#9611) (#5181) (#3709)

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Goran Obradovic <gobradovic@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Goran Obradovic <gobradovic@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>

* Cherrypick changelog entry.

Co-authored-by: The Magician <magic-modules@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Goran Obradovic <gobradovic@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
@modular-magician modular-magician deleted the downstream-pr-05e4e2c64f59114be501a75bcd6bca987eaa74f5 branch November 16, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cloud Composer v2
1 participant