-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_ecs_task_execution: Add new resource #29978
base: main
Are you sure you want to change the base?
Conversation
Community NoteVoting for Prioritization
For Submitters
|
If this approach looks OK, I can work up some docs |
|
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { | ||
acctest.PreCheck(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear to me what this "not enough arguments in call to acctest.PreCheck" error would have me do instead. All the other examples I see in the repo are calling acctest.PreCheck
and I don't see any clear alternatives in internal/acctest
Please someone merge this, it would be so helpful! maybe someone like @jar-b who created the similar data source could help move this forward |
Is there any chance this will get merged? I would like to use it to run an ECS task only when applying, and this should do just that |
I would love to see support for CRUD as well just like |
Description
This pull request adds an
aws_ecs_task_execution
resource to complementdata.aws_ecs_task_execution
as added in #29783Relations
Relates #29871
References
This is almost an exact copy of
task_execution_data_source.go
and its tests. The main difference between the resource schemas is thatForceNew
has been added to all non-computed fields in the schema. There are possibly better patterns for making the code between the two more DRY.Output from Acceptance Testing
I'm unable to run
testacc
successfully because a process in our account automatically tags the default security group of any VPC if it has anyingress
oregress
rules. This causes therefresh
to always come back dirty...