Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_task_execution: Add new resource #29978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

md5
Copy link
Contributor

@md5 md5 commented Mar 14, 2023

Description

This pull request adds an aws_ecs_task_execution resource to complement data.aws_ecs_task_execution as added in #29783

Relations

Relates #29871

References

This is almost an exact copy of task_execution_data_source.go and its tests. The main difference between the resource schemas is that ForceNew has been added to all non-computed fields in the schema. There are possibly better patterns for making the code between the two more DRY.

Output from Acceptance Testing

I'm unable to run testacc successfully because a process in our account automatically tags the default security group of any VPC if it has any ingress or egress rules. This causes the refresh to always come back dirty...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 14, 2023
@md5
Copy link
Contributor Author

md5 commented Mar 14, 2023

If this approach looks OK, I can work up some docs

@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2023

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(t)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me what this "not enough arguments in call to acctest.PreCheck" error would have me do instead. All the other examples I see in the repo are calling acctest.PreCheck and I don't see any clear alternatives in internal/acctest

@mcfedr
Copy link

mcfedr commented Aug 11, 2023

Please someone merge this, it would be so helpful!

maybe someone like @jar-b who created the similar data source could help move this forward

@mikicz
Copy link

mikicz commented Jan 10, 2024

Is there any chance this will get merged? I would like to use it to run an ECS task only when applying, and this should do just that

@briantist
Copy link

I would love to see support for CRUD as well just like aws_lambda_invocation resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. new-resource Introduces a new resource. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants