Skip to content

Add support for write-only attributes #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Dec 11, 2024

Closes TF-22967

This PR:

I've not included any changes in the sanitize package because that package appears to be specific to Sensitive values, and is irrelevant to ephemeral resources & write-only attributes.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@SarahFrench SarahFrench changed the title Add write only attr support Add support for write-only attrbiutes Dec 11, 2024
@SarahFrench SarahFrench changed the title Add support for write-only attrbiutes Add support for write-only attributes Dec 11, 2024
@SarahFrench SarahFrench force-pushed the add-write-only-attr-support branch from 2aafce4 to a625780 Compare December 11, 2024 15:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tribute
…ProviderSchemas structs
@SarahFrench SarahFrench force-pushed the add-write-only-attr-support branch from a625780 to be2727d Compare December 11, 2024 15:43
@SarahFrench SarahFrench marked this pull request as ready for review December 11, 2024 15:51
@SarahFrench SarahFrench requested review from a team as code owners December 11, 2024 15:51
@SarahFrench
Copy link
Member Author

Merging to main now, even though the WO attribute feature is still in development. Releasing these changes prior to that feature being released should be fine, the same way that fields currently tolerate having some schema behaviours as false. I'll seek some feedback before making a release though.

@SarahFrench SarahFrench merged commit 338fe14 into main Dec 12, 2024
8 checks passed
@SarahFrench SarahFrench deleted the add-write-only-attr-support branch December 12, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants