feat: bump to use node20 runtime #346
Conversation
|
needs a major version release after the PR merge |
|
cc @bendbennett , this is ready to go. 🙏 |
|
cc @austinvalle |
|
I dont understand what is going on, can someone help take a look at this? |
There was a problem hiding this comment.
Hey there @chenrui333 👋🏻 , apologies on the delay here. This PR overall LGTM, we'll need a changelog but I can PR those in.
We haven't cut a release of this action in almost a year, so I want to double check some other things, but I plan to merge this PR and release a v3.0.0 later this week.
Signed-off-by: Rui Chen <rui@chenrui.dev> fix action refs for `actions/reusable-workflows` Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
@austinvalle updated the action refs and rebased to the latest master, also add the changelog entry. Let me know if it works better now. Thanks! |
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
@austinvalle all green 🎉 |
There was a problem hiding this comment.
LGTM, I pushed a couple changes to the PR:
- Reverted some of the changes to
.github/workflows/continuous-integration.yml, unforuntately our GH organization is limited to specific SHA commits of workflows that are approved. These are managed by a separate system so I just kept the node upgrades 👍🏻 - Switched the changelog entry to be a
changieentry
Thanks for your patience and contribution @chenrui333! I'm going to be releasing v3.0.0 early next week once I merge a couple other PRs into setup-terraform
Sounds good and thank you for getting this going! |
| @@ -0,0 +1,5 @@ | |||
| kind: NOTES | |||
There was a problem hiding this comment.
Should this not be a breaking change just like the last node update?
https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md?plain=1#L62-L64
There was a problem hiding this comment.
Besides this change would require newer runner versions, it should not break anything.
Closes #366
This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)
Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.
This PR updates the default runtime to node20, rather then node16
relates to actions/runner#2732