Skip to content

Commit

Permalink
feat: bump to use node20 runtime (#346)
Browse files Browse the repository at this point in the history
* feat: bump to use node20 runtime

Signed-off-by: Rui Chen <rui@chenrui.dev>

fix action refs for `actions/reusable-workflows`

Signed-off-by: Rui Chen <rui@chenrui.dev>

* docs: update changelog

Signed-off-by: Rui Chen <rui@chenrui.dev>

* workflows: update `actions/reusable-workflows` to use node20

Signed-off-by: Rui Chen <rui@chenrui.dev>

* chore: update dist file

* clean up PR for merge

* add node version

* update dist

* switch changelog

---------

Signed-off-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Austin Valle <austinvalle@gmail.com>
  • Loading branch information
chenrui333 and austinvalle committed Oct 27, 2023
1 parent 599d383 commit 9507e1d
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changes/unreleased/NOTES-20231027-085131.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: NOTES
body: Updated default runtime to node20
time: 2023-10-27T08:51:31.923295-04:00
custom:
Issue: "346"
7 changes: 7 additions & 0 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ jobs:
check-dist:
name: Check dist/ directory
uses: actions/reusable-workflows/.github/workflows/check-dist.yml@a8533f184b279cfc1b2dd6a96ed2f097ccf81189
with:
node-version: 20.x
node-caching: npm

test:
name: Test
uses: actions/reusable-workflows/.github/workflows/basic-validation.yml@a8533f184b279cfc1b2dd6a96ed2f097ccf81189
with:
node-version: 20.x
node-caching: npm
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: 18
node-version: 20
- name: Update package version
run: npm version "${{ inputs.versionNumber }}" --git-tag-version false
- name: Git push
Expand Down Expand Up @@ -109,9 +109,9 @@ jobs:
run: |
git config --global user.name "${{ env.CI_COMMIT_AUTHOR }}"
git config --global user.email "${{ env.CI_COMMIT_EMAIL }}"
git tag "${{ inputs.versionNumber }}"
git tag -f "${{ needs.major-version.outputs.version }}"
git tag -f "${{ needs.major-version.outputs.version }}"
git push "https://${{ env.CI_COMMIT_AUTHOR }}:${{ secrets.TF_DEVEX_COMMIT_GITHUB_TOKEN }}@github.com/${{ github.repository }}.git" "${{ inputs.versionNumber }}"
git push "https://${{ env.CI_COMMIT_AUTHOR }}:${{ secrets.TF_DEVEX_COMMIT_GITHUB_TOKEN }}@github.com/${{ github.repository }}.git" -f "${{ needs.major-version.outputs.version }}"
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ inputs:
default: 'true'
required: false
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
branding:
icon: 'terminal'
Expand Down

0 comments on commit 9507e1d

Please sign in to comment.