Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use a native select element instead of @reach/listbox #942

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

dstaley
Copy link
Contributor

@dstaley dstaley commented Apr 26, 2023 β€’

🎟️ Asana Task
πŸ” Preview Link


Description

In our on-going effort to replace our usage of the now-deprecated Reach UI components, this PR replaces our usage of @reach/listbox in react-code-block with a native <select> element that affords virtually the same exact experience.

Preview Link

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

πŸ¦‹ Changeset detected

Latest commit: 3ec5b35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-code-block Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 26, 2023 β€’

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 26, 2023 10:28pm

@dstaley dstaley requested a review from a team April 26, 2023 22:38
@dstaley dstaley added the release:canary Triggers a canary release for commits to this pull request label Apr 26, 2023
@github-actions
Copy link
Contributor

πŸ“¦ Canary Packages Published

Latest commit: 3ec5b35

Published 1 packages

@hashicorp/react-code-block@6.3.0-canary-20230426224812

npm install @hashicorp/react-code-block@canary

Copy link
Contributor

@kendallstrautman kendallstrautman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Seems like we need to update the focus styles to match HDS but we can do that in dev portal with an override or something. Thank you πŸ™‡πŸ»

@dstaley dstaley merged commit 8d1faaa into main Apr 27, 2023
@dstaley dstaley deleted the ds.code-block-select branch April 27, 2023 18:27
@hashibot-web hashibot-web mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants