fix(code-block): fix language-undefined in MDX CodeTabs

[zchsh]

🎟️ Asana Task
🔍 Preview Link

---

Fixes a bug where shell-session snippets within CodeTabs would copy correctly via the Copy button, but would still include the $ character when selected and copied by clicking and dragging.

Details

Removes a className attribute that passed a non-existent className, which also dropped any incoming classNames. This was originally intended to prevent the possibility of custom styling via MDX, but has the side-effect of dropping the language-<language> class. That language class was unused for the most part (highlighting happens on the server!), but has become important for full functionality since #736 shipped.

This approach has been proven out in hashicorp/dev-portal#1268. Screenshots below are from that PR, demonstrating that with this fix, we go from the issue-causing language-undefined to language-shell-session.

Before

After

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

• Add Asana and Preview links above.
• Conduct thorough self-review.
• Add or update tests as appropriate.
• Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
• Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
• Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

[changeset-bot]

🦋 Changeset detected

Latest commit: f15c0a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hashicorp/react-code-block	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-components	✅ Ready (Inspect)	Visit Preview	Oct 19, 2022 at 11:57PM (UTC)

[github-actions]

📦 Canary Packages Published

Latest commit: f15c0a3

Published 1 packages

@hashicorp/react-code-block@6.2.1-canary-20221019235743

npm install @hashicorp/react-code-block@canary

[brkalow]

Good catch! Do you think there's any reason why we would want to retain the ignoring of other passed className values?

[zchsh]

@brkalow I think my previous reasoning was to try to preemptively prevent any custom styling in MDX contexts. But in retrospect I don't think that made all that much sense, custom styling would probably happen through the style prop anyways? 🤔 So I don't see any strong reason to retain the "ignore incoming className" behaviour.

[brkalow]

Makes sense, thanks for the insight!