feat: use next/image instead of react-inline-svg #1007
Merged
+68
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b91b03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dstaley
requested review from
a team and
pbortnick
and removed request for
a team
pbortnick
reviewed
Dec 6, 2023
| @@ -60,7 +60,7 @@ | |||
| transition: transform 0.4s; | |||
| transform: var(--icon-transform); | |||
|
|
|||
| & svg { | |||
| & img { | |||
There was a problem hiding this comment.
Since this is no longer an svg, the fill and stroke styles below aren't applied and the color is changed. I know you mentioned we are accepting slight rendering differences in the PR description so if this is one of those disregard!
There was a problem hiding this comment.
Honestly, I think this is fine. Like you mentioned, we are deprecating these anyways.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Asana Task
🔍 Preview Link
Description
This PR replaces instances of
?includeandreact-inline-svgwithnext/imageor actual inlined SVGs where appropriate. The packages updated in this PR are used on hashicorp.com; other packages likely won't be updated unless they're transitive dependencies of the packages modified in this PR. There may be slight rendering differences due to the switch but this is acceptable given that these components are relatively ancient and should be replaced (all but code-block),Packages updated:
PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.