Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: warn if no requirements specified #12638

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

When users call packer init on a template that does not specify a required_plugin block, the command succeeds but does nothing, which is not helpful for users that may expect their plugins to install.

To remedy that problem, we now output a message like what packer plugins required does on templates without such a block, so that users have an idea of what to change in order to get the command to work.

Verified

This commit was signed with the committer’s verified signature.
kwasniew Mateusz Kwasniewski
When users call `packer init' on a template that does not specify a
`required_plugin' block, the command succeeds but does nothing, which is
not helpful for users that may expect their plugins to install.

To remedy that problem, we now output a message like what `packer
plugins required' does on templates without such a block, so that users
have an idea of what to change in order to get the command to work.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner September 27, 2023 14:50
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.9.x Backport PR changes to `release/1.9.x` enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants