Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PLSP-related environment variables #12576

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

lbajolet-hashicorp
Copy link
Contributor

Since we added support for PLSPs recently, and it will be released as part of 1.9.3, we add some documentation regarding the environment variables we added, and a note regarding their relation to PLSP support.

Verified

This commit was signed with the committer’s verified signature.
hegerdes Henrik Gerdes
Since the HCP_PACKER_PROJECT_ID environment variable was introduced for
supporting project-level service principals, we add some documentation
snippet to highlight its existence and document its usage a bit.
In addition to the HCP_PROJECT_ID, we added support for the
HCP_ORGANIZATION_ID in Packer, so we add some docs to cover this as a
variable that can be set by users.
@lbajolet-hashicorp lbajolet-hashicorp added docs backport/website Backport PR changes to `stable-website` and latest release branch backport/1.9.x Backport PR changes to `release/1.9.x` labels Aug 16, 2023
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner August 16, 2023 14:49
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out! thanks for adding the docs. I left a few small suggestions but otherwise good to go. Approving in advance so you can merge after making the changes.

Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/website Backport PR changes to `stable-website` and latest release branch backport/1.9.x Backport PR changes to `release/1.9.x` docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants