Bump Go tooling to version 1.20 #12380
Merged
+76
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix go vet issue * Bump Go tooling to version 1.20 * Update workflows to use go-version file
lbajolet-hashicorp
approved these changes
Apr 28, 2023
| @@ -53,6 +53,7 @@ func TestBuildCommand_RunContext_CtxCancel(t *testing.T) { | |||
| } | |||
|
|
|||
| for _, tt := range tests { | |||
| tt := tt | |||
There was a problem hiding this comment.
I don't understand that change, is there something missing here?
There was a problem hiding this comment.
Ah yes so in Go 1.20 the vet command will call this out as an issue. Since this is a common mistake.
Take from the Go release notes
The vet tool now reports references to loop variables following a call to [T.Parallel()](https://tip.golang.org/pkg/testing/#T.Parallel) within subtest function bodies. Such references may observe the value of the variable from a different iteration (typically causing test cases to be skipped) or an invalid state due to unsynchronized concurrent access.
nywilken
pushed a commit
that referenced
this pull request
Apr 28, 2023
Bump Go tooling to version 1.20
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.