Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/console: Add config-type flag to command help #12360

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

nywilken
Copy link
Contributor

It is not clear that the console command runs in legacy JSON mode by default and that users can specify the config-type flag to toggle HCL2 mode. This change adds the config-type flag to the command's help text to alert users of the gotcha.

In the next minor Packer release the console command will be updated to default to HCL2 mode.

Relates to: #12359
Relates to: #10603

It is not clear that the console command runs in legacy JSON mode by
default and that users can specify the -config-type flag to toggle HCL2
mode. This change adds the config-type flag to the command's help text
to alert users of the gotcha.

In the next minor Packer release the console command will be updated to
default to HCL2 mode.

Relates to: #12359
Relates to: #10603
@nywilken nywilken requested a review from a team as a code owner April 12, 2023 18:05
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nywilken nywilken added the backport/1.8.x Backport PR changes to `release/1.8.x` label Apr 12, 2023
@nywilken nywilken merged commit e0a5286 into main Apr 12, 2023
@nywilken nywilken deleted the nywilken/console-config-type-flag branch April 12, 2023 18:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8.x Backport PR changes to `release/1.8.x`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants